Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use procgen #639

Closed
wants to merge 5 commits into from
Closed

Use procgen #639

wants to merge 5 commits into from

Conversation

dfilan
Copy link
Collaborator

@dfilan dfilan commented Nov 30, 2022

Description

Import procgen and add configs to train_rl and eval_policy for procgen environments.

This is basically a very pared-down version of #563 that just enables things that are immediately useful to me.

Testing

Added a test that train_rl works on coinrun, the test passes.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #639 (1ee83a5) into master (1dd4c8f) will decrease coverage by 0.33%.
The diff coverage is 70.47%.

❗ Current head 1ee83a5 differs from pull request most recent head 245e881. Consider uploading reports for the commit 245e881 to get more accurate results

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   97.51%   97.17%   -0.34%     
==========================================
  Files          85       85              
  Lines        8316     8421     +105     
==========================================
+ Hits         8109     8183      +74     
- Misses        207      238      +31     
Impacted Files Coverage Δ
src/imitation/scripts/config/eval_policy.py 72.72% <66.66%> (-3.99%) ⬇️
src/imitation/scripts/config/train_rl.py 75.00% <68.75%> (-3.95%) ⬇️
tests/scripts/test_scripts.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dfilan dfilan marked this pull request as draft November 30, 2022 02:22
@dfilan
Copy link
Collaborator Author

dfilan commented Nov 30, 2022

Procgen has some issues with reward learning, so it probably doesn't make sense to merge this into imitation. (Also it's kind of interesting that tests seem to be 'failing' due to timing out as a result of adding new tests?)

@dfilan dfilan closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant