Fix canPin predicate #6169
Merged
Fix canPin predicate #6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirox
reviewed
Jul 22, 2023
| @@ -10,6 +10,10 @@ const mixerExitQuery = exitQuery(mixerQuery); | |||
|
|
|||
| export function mixerAnimatableSystem(world: HubsWorld): void { | |||
| initializeEnterQuery(world).forEach(eid => { | |||
| if (entityExists(world, eid)) { | |||
There was a problem hiding this comment.
This line breaks mixer animation. I think here should be !entityExists(world, eid).
Made a PR for the fix #6180
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
canPinpredicate assumesinitialDataexists for a givencreateMessageData. It needs to first check whether the entity is amedia, sincemediaare the only things that are pinnable.Two unrelated changes:
mixerAnimatableSystemthat can cause the app the become unresponsive.createNetworkedMediahelper function so thatinitialDatais type checked for media.