Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow folks to close the full-screen Preferences modal by pressing the Escape key #6026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zfox23
Copy link
Contributor

@zfox23 zfox23 commented Apr 9, 2023

Hello! When I was playing with Hubs' great new demo room recently, I went into Preferences to boost the room's media volume. I noticed that I couldn't close the full-screen Preferences window with an Escape keypress, though I felt like I should be able to (both from a "UX patterns" perspective and because other elements within the UI are closeable with Esc).

This PR lets people close the Preferences window with Escape and get right back to the action without leaving their keyboard.


Also, I noticed that when I ran npm run test as per the Contributing guidelines, I got this error:
image

I'm not sure if this is worth opening a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant