-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds scripts for usual steps #359
base: master
Are you sure you want to change the base?
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that these seem to be nice convenience commands, but I'm not sure why this should affect IDEs at all. Can you expand on that?
As to the scripts themselves.
We have had issues in the past with running terminal commands via the asynchronous Node functions and they are harder to read, so the synchronous versions should be used instead.
The new commands also need documentation in the readme.
Without these scripts, one needs a terminal window open to enter the kubectl commands. With the new scripts, in an IDE, one can click on the scripts to run them, and not keep a terminal window open. The scripts work equally well when run from the command line. |
588edd4
to
88a892a
Compare
This makes it easy to perform steps from an IDE.