[Mozilla Branding Removal] First pass at removing Mozilla references, links, images, etc. #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Mozilla links to the Hubs-Foundation versions, or to placeholders until suitable documents can be recreated. Placeholders are marked with (TBD) where possible. References to Mozilla's name are either removed or changed to refer to Hubs, its community, or the Hubs Foundation. Note: links in .env files, GitHub workflows, and habitat files are unchanged to ensure nothing breaks. The same for references to mozillareality.
Rewrite the PROMOTION.md file to be generic and applicable to all Hubs instances. Removes the right for the owner of the instance to use the promoted scene in advertising without explicit consent.
The Mozilla logo is replaced with the Hubs duck logo with white horizontal text. The Spoke logo is replaced with the Spoke icon with white horizontal text.
Exairnous
force-pushed
the
remove-mozilla-branding-1
branch
from
8edd846
to
d07787a
Compare
Exairnous
force-pushed
the
remove-mozilla-branding-1
branch
from
90dcc2d
to
416eec5
Compare
|
Seems the workflows won't run properly until we get a docker registry in working order. |
|
@eyesnareinc I haven't been able to test this in hubs-compose (I can't get mine to work for some reason), but I have been able to run it locally and it does at least run (I was not able to test everything running it locally). Maybe you could try it in your hubs-compose and see if it works? I think it should, so I'm marking it as ready for review and requesting your review of it :) Assuming you like the content of the PR, I think we just merge despite the failing checks once/if you give it the green light. |
|
As discussed at a governance team meeting, I am merging this on my own recognizance. |
|
Comment viewing Mozilla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mozilla links and references have been either removed, updated, or replaced with placeholders. Placeholders are marked with (TBD) where possible.
The PROMOTION.md file has been rewritten to be generic and no longer conveys the automatic right to use promoted scenes in advertising.
The two images with Mozilla branding have been replaced with non-Mozilla counterparts.
More details can be found in the commit messages.
Additional Notes:
src/editor/nodes/TroikaTextNode.js should be checked to make sure it isn't a credit and should actually be removed.
links in .env files and habitat files are unchanged to ensure nothing breaks. The same for references to mozillareality
links in yarn-error.log are unchanged because I think they have a historical context. It's possible this whole file should be removed in the future, though.
The reference to Mozilla in src/ui/assets/sources/SketchfabSource.js I have deemed a credit and left unchanged. For reference, this what I left unchanged:
label: "Mozilla Playground - by Tombolaso"I have left these references unchanged as I believe they don't constitute branding: