Fix UWP support #831
Open
Fix UWP support #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheStormN
reviewed
Jun 24, 2024
| @@ -81,7 +81,7 @@ | |||
| #ifdef _MSC_VER | |||
| # pragma warning(push) | |||
| // warning C4127: conditional expression is constant | |||
| # pragma warning(disable : 4127) | |||
| # pragma warning(disable : 4127 4996) | |||
There was a problem hiding this comment.
What is the code which causes 4996?
There was a problem hiding this comment.
I just copied this from the original UWP support vcpkg patch. Looks like it's originally from here. I don't have a Windows dev environment, so I can't test these changes directly, but I know it fixed the UWP CI tests in vcpkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes come from the Vcpkg package update. I believe these would be better to have in the library itself.
Main change is to move
convert_utf8_to_utf16outside the!WINRTcheck, since it doesn't depend on any features unavailable in UWP.