cmake 3.5 compatibility #548
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a few minor workarounds to make CMakeLists.txt compatible with cmake 3.5: - `$<IF` isn't supported before 3.8, but all the uses of `$<IF` here are actually simpler to write without `$<IF`. - VERSION_GREATER_EQUAL isn't supported before 3.7, but is easily worked around with a NOT ... VERSION_LESS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few minor workarounds to make CMakeLists.txt compatible with cmake 3.5 (which is still out in the wild as it is Ubuntu xenial's cmake version):
$<IFisn't supported before 3.8, but all the uses of$<IFhere are actually simpler to write without$<IF.VERSION_GREATER_EQUALisn't supported before 3.7, but is easily worked around with aNOT ... VERSION_LESSFixes #547