Clean-up of the exceptions

io-hotmoka-node-local/src/main/java/io/hotmoka/node/local/internal/NonInitialResponseBuilderImpl.java

@@ -19,7 +19,6 @@
 import static java.math.BigInteger.ONE;
 import static java.math.BigInteger.ZERO;
 
-import java.io.IOException;
 import java.math.BigInteger;
 import java.security.NoSuchAlgorithmException;
 import java.util.LinkedList;
@@ -52,7 +51,6 @@
 import io.hotmoka.stores.EngineClassLoader;
 import io.hotmoka.stores.StoreException;
 import io.hotmoka.stores.StoreTransaction;
-import io.hotmoka.stores.UnsupportedVerificationVersionException;
 
 /**
  * Implementation of the creator of the response for a non-initial transaction. Non-initial transactions consume gas,
@@ -105,8 +103,13 @@ protected boolean transactionIsSigned() {
 	}
 
 	@Override
-	protected EngineClassLoader mkClassLoader() throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
-		return storeTransaction.getClassLoader(request.getClasspath(), consensus);
+	protected EngineClassLoader mkClassLoader() throws NodeException, TransactionRejectedException {
+		try {
+			return storeTransaction.getClassLoader(request.getClasspath(), consensus);
+		}
+		catch (StoreException e) {
+			throw new NodeException(e);
+		}
 	}
 
 	/**

io-hotmoka-node-local/src/main/java/io/hotmoka/node/local/internal/transactions/AbstractResponseBuilder.java

@@ -132,7 +132,7 @@ public final void replaceReverifiedResponses() throws NoSuchElementException, Un
 	 * @throws UnsupportedVerificationVersionException if the verification version is not available
 	 * @throws IOException if there was an I/O error while accessing some jar
 	 */
-	protected abstract EngineClassLoader mkClassLoader() throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException ;
+	protected abstract EngineClassLoader mkClassLoader() throws NodeException, TransactionRejectedException;
 
 	/**
 	 * Wraps the given throwable in a {@link io.hotmoka.node.api.TransactionException}, if it not

io-hotmoka-node-local/src/main/java/io/hotmoka/node/local/internal/transactions/GameteCreationResponseBuilder.java

@@ -16,23 +16,20 @@
 
 package io.hotmoka.node.local.internal.transactions;
 
-import java.io.IOException;
 import java.lang.reflect.InvocationTargetException;
-import java.util.NoSuchElementException;
 import java.util.stream.Stream;
 
 import io.hotmoka.node.TransactionResponses;
 import io.hotmoka.node.api.NodeException;
 import io.hotmoka.node.api.TransactionRejectedException;
-import io.hotmoka.node.api.UnknownReferenceException;
 import io.hotmoka.node.api.requests.GameteCreationTransactionRequest;
 import io.hotmoka.node.api.responses.GameteCreationTransactionResponse;
 import io.hotmoka.node.api.transactions.TransactionReference;
 import io.hotmoka.node.local.AbstractInitialResponseBuilder;
 import io.hotmoka.node.local.internal.AbstractLocalNodeImpl;
 import io.hotmoka.stores.EngineClassLoader;
+import io.hotmoka.stores.StoreException;
 import io.hotmoka.stores.StoreTransaction;
-import io.hotmoka.stores.UnsupportedVerificationVersionException;
 
 /**
  * The creator of a response for a transaction that creates a gamete.
@@ -52,8 +49,13 @@ public GameteCreationResponseBuilder(TransactionReference reference, GameteCreat
 	}
 
 	@Override
-	protected EngineClassLoader mkClassLoader() throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
-		return storeTransaction.getClassLoader(request.getClasspath(), consensus);
+	protected EngineClassLoader mkClassLoader() throws NodeException {
+		try {
+			return storeTransaction.getClassLoader(request.getClasspath(), consensus);
+		}
+		catch (StoreException e) {
+			throw new NodeException(e);
+		}
 	}
 
 	@Override

io-hotmoka-node-local/src/main/java/io/hotmoka/node/local/internal/transactions/InitializationResponseBuilder.java

@@ -16,21 +16,17 @@
 
 package io.hotmoka.node.local.internal.transactions;
 
-import java.io.IOException;
-import java.util.NoSuchElementException;
-
 import io.hotmoka.node.TransactionResponses;
 import io.hotmoka.node.api.NodeException;
 import io.hotmoka.node.api.TransactionRejectedException;
-import io.hotmoka.node.api.UnknownReferenceException;
 import io.hotmoka.node.api.requests.InitializationTransactionRequest;
 import io.hotmoka.node.api.responses.InitializationTransactionResponse;
 import io.hotmoka.node.api.transactions.TransactionReference;
 import io.hotmoka.node.local.AbstractInitialResponseBuilder;
 import io.hotmoka.node.local.internal.AbstractLocalNodeImpl;
 import io.hotmoka.stores.EngineClassLoader;
+import io.hotmoka.stores.StoreException;
 import io.hotmoka.stores.StoreTransaction;
-import io.hotmoka.stores.UnsupportedVerificationVersionException;
 
 /**
  * The creator of a response for a transaction that initializes a node.
@@ -62,7 +58,12 @@ protected InitializationTransactionResponse body() {
 	}
 
 	@Override
-	protected EngineClassLoader mkClassLoader() throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
-		return storeTransaction.getClassLoader(request.getClasspath(), consensus); // currently not used for this transaction
+	protected EngineClassLoader mkClassLoader() throws NodeException {
+		try {
+			return storeTransaction.getClassLoader(request.getClasspath(), consensus); // currently not used for this transaction
+		}
+		catch (StoreException e) {
+			throw new NodeException(e);
+		}
 	}
 }

io-hotmoka-node-local/src/main/java/io/hotmoka/node/local/internal/transactions/JarStoreInitialResponseBuilder.java

@@ -17,20 +17,19 @@
 package io.hotmoka.node.local.internal.transactions;
 
 import java.io.IOException;
-import java.util.NoSuchElementException;
 
 import io.hotmoka.instrumentation.InstrumentedJars;
 import io.hotmoka.node.TransactionResponses;
 import io.hotmoka.node.api.NodeException;
 import io.hotmoka.node.api.TransactionRejectedException;
-import io.hotmoka.node.api.UnknownReferenceException;
 import io.hotmoka.node.api.requests.JarStoreInitialTransactionRequest;
 import io.hotmoka.node.api.responses.JarStoreInitialTransactionResponse;
 import io.hotmoka.node.api.transactions.TransactionReference;
 import io.hotmoka.node.local.AbstractInitialResponseBuilder;
 import io.hotmoka.node.local.internal.AbstractLocalNodeImpl;
 import io.hotmoka.stores.EngineClassLoader;
 import io.hotmoka.stores.EngineClassLoaderImpl;
+import io.hotmoka.stores.StoreException;
 import io.hotmoka.stores.StoreTransaction;
 import io.hotmoka.stores.UnsupportedVerificationVersionException;
 import io.hotmoka.verification.VerificationException;
@@ -54,10 +53,19 @@ public JarStoreInitialResponseBuilder(TransactionReference reference, JarStoreIn
 	}
 
 	@Override
-	protected EngineClassLoader mkClassLoader() throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
+	protected EngineClassLoader mkClassLoader() throws NodeException, TransactionRejectedException {
 		// we redefine this method, since the class loader must be able to access the
 		// jar that is being installed and its dependencies, in order to instrument them
-		return new EngineClassLoaderImpl(request.getJar(), request.getDependencies(), storeTransaction, consensus);
+		try {
+			return new EngineClassLoaderImpl(request.getJar(), request.getDependencies(), storeTransaction, consensus);
+		}
+		catch (StoreException e) {
+			throw new NodeException(e);
+		}
+		catch (ClassNotFoundException e) {
+			// the request is trying to install a jar with inconsistent dependencies
+			throw new TransactionRejectedException(e);
+		}
 	}
 
 	@Override

io-hotmoka-node-local/src/main/java/io/hotmoka/node/local/internal/transactions/JarStoreResponseBuilder.java

@@ -16,9 +16,7 @@
 
 package io.hotmoka.node.local.internal.transactions;
 
-import java.io.IOException;
 import java.math.BigInteger;
-import java.util.NoSuchElementException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.stream.Stream;
@@ -27,16 +25,15 @@
 import io.hotmoka.node.TransactionResponses;
 import io.hotmoka.node.api.NodeException;
 import io.hotmoka.node.api.TransactionRejectedException;
-import io.hotmoka.node.api.UnknownReferenceException;
 import io.hotmoka.node.api.requests.JarStoreTransactionRequest;
 import io.hotmoka.node.api.responses.JarStoreTransactionResponse;
 import io.hotmoka.node.api.transactions.TransactionReference;
 import io.hotmoka.node.local.AbstractNonInitialResponseBuilder;
 import io.hotmoka.node.local.internal.AbstractLocalNodeImpl;
 import io.hotmoka.stores.EngineClassLoader;
 import io.hotmoka.stores.EngineClassLoaderImpl;
+import io.hotmoka.stores.StoreException;
 import io.hotmoka.stores.StoreTransaction;
-import io.hotmoka.stores.UnsupportedVerificationVersionException;
 import io.hotmoka.verification.VerifiedJars;
 
 /**
@@ -58,10 +55,19 @@ public JarStoreResponseBuilder(TransactionReference reference, JarStoreTransacti
 	}
 
 	@Override
-	protected EngineClassLoader mkClassLoader() throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
+	protected EngineClassLoader mkClassLoader() throws NodeException, TransactionRejectedException {
 		// we redefine this method, since the class loader must be able to access the
 		// jar that is being installed and its dependencies, in order to instrument them
-		return new EngineClassLoaderImpl(request.getJar(), request.getDependencies(), storeTransaction, consensus);
+		try {
+			return new EngineClassLoaderImpl(request.getJar(), request.getDependencies(), storeTransaction, consensus);
+		}
+		catch (StoreException e) {
+			throw new NodeException(e);
+		}
+		catch (ClassNotFoundException e) {
+			// the request is trying to install a jar with inconsistent dependencies
+			throw new TransactionRejectedException(e);
+		}
 	}
 
 	@Override

io-hotmoka-stores/src/main/java/io/hotmoka/stores/AbstractStoreTransaction.java

@@ -16,7 +16,6 @@
 
 package io.hotmoka.stores;
 
-import java.io.IOException;
 import java.math.BigInteger;
 import java.security.InvalidKeyException;
 import java.security.PublicKey;
@@ -39,8 +38,6 @@
 import io.hotmoka.crypto.api.SignatureAlgorithm;
 import io.hotmoka.exceptions.UncheckFunction;
 import io.hotmoka.node.FieldSignatures;
-import io.hotmoka.node.api.NodeException;
-import io.hotmoka.node.api.UnknownReferenceException;
 import io.hotmoka.node.api.nodes.ConsensusConfig;
 import io.hotmoka.node.api.requests.InitializationTransactionRequest;
 import io.hotmoka.node.api.requests.SignedTransactionRequest;
@@ -256,13 +253,20 @@ public final boolean signatureIsValidUncommitted(SignedTransactionRequest<?> req
 	}
 
 	@Override
-	public final EngineClassLoader getClassLoader(TransactionReference classpath, ConsensusConfig<?,?> consensus) throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
-		var classLoader = store.classLoaders.get(classpath);
-		if (classLoader != null)
-			return classLoader;
+	public final EngineClassLoader getClassLoader(TransactionReference classpath, ConsensusConfig<?,?> consensus) throws StoreException {
+		try {
+			var classLoader = store.classLoaders.get(classpath);
+			if (classLoader != null)
+				return classLoader;
 
-		var classLoader2 = new EngineClassLoaderImpl(null, Stream.of(classpath), this, consensus);
-		return store.classLoaders.computeIfAbsent(classpath, _classpath -> classLoader2);
+			var classLoader2 = new EngineClassLoaderImpl(null, Stream.of(classpath), this, consensus);
+			return store.classLoaders.computeIfAbsent(classpath, _classpath -> classLoader2);
+		}
+		catch (ClassNotFoundException e) {
+			// since the class loader is created from transactions that are already in the store,
+			// they should be consistent and never miss a dependent class
+			throw new StoreException(e);
+		}
 	}
 
 	private boolean verifiesSignatureUncommitted(SignatureAlgorithm signature, SignedTransactionRequest<?> request) throws StoreException {

io-hotmoka-stores/src/main/java/io/hotmoka/stores/EngineClassLoaderImpl.java

@@ -164,13 +164,10 @@ public final class EngineClassLoaderImpl implements EngineClassLoader {
 	 * @param dependencies the dependencies
 	 * @param node the node for which the class loader is created
 	 * @param consensus the consensus parameters to use for reverification
-	 * @throws ClassNotFoundException if some class of the Takamaka runtime cannot be loaded
-	 * @throws UnsupportedVerificationVersionException if the verification version is not available
-	 * @throws IOException if there was an I/O error while accessing some jar
-	 * @throws NodeException 
-	 * @throws NoSuchElementException 
+	 * @throws ClassNotFoundException if some class of the dependencies cannot be found
+	 * @throws StoreException 
 	 */
-	public EngineClassLoaderImpl(byte[] jar, Stream<TransactionReference> dependencies, StoreTransaction<?> storeTransaction, ConsensusConfig<?,?> consensus) throws ClassNotFoundException, UnsupportedVerificationVersionException, IOException, NoSuchElementException, UnknownReferenceException, NodeException {
+	public EngineClassLoaderImpl(byte[] jar, Stream<TransactionReference> dependencies, StoreTransaction<?> storeTransaction, ConsensusConfig<?,?> consensus) throws StoreException, ClassNotFoundException {
 		try {
 			var dependenciesAsList = dependencies.collect(Collectors.toList());
 
@@ -210,11 +207,8 @@ public EngineClassLoaderImpl(byte[] jar, Stream<TransactionReference> dependenci
 			this.balanceField = contract.getDeclaredField("balance");
 			this.balanceField.setAccessible(true); // it was private
 		}
-		catch (IllegalArgumentException e) {
-			throw e;
-		}
 		catch (NoSuchMethodException | NoSuchFieldException e) {
-			throw new RuntimeException("unexpected class change", e);
+			throw new StoreException("Unexpected class change", e);
 		}
 	}