-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(2494): Incidents: Add the ability to edit incident details #2689
base: master
Are you sure you want to change the base?
Conversation
Merge HospitalRun/hospitalrun-frontend to riiniii/hospitalrun-frontend
…ResolveIncident to useUpdateIncident, and include previously merged page (Visitform)
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/JDF9CwtuK2XJ28HSvFQGQmRx1fSe |
cla was signed but showing as not signed, waiting on this |
@tehkapa could you add james + cynthia again for the reviewers? I can't seem to add them by myself |
@riiniii The issue with the CLA is that every author every commit in this PR has to sign the CLA. I would edit the commits to remove the authorship of Renee Huang, as it seems that they do not have a GitHub account and thus cannot sign the CLA. @tehkapa It seems like a good amount of contributors are running into this -- should the CLA only consider the GitHub author of the PR? |
@@ -1,13 +1,12 @@ | |||
import subDays from 'date-fns/subDays' | |||
|
|||
import useResolveIncident from '../../../incidents/hooks/useResolveIncident' | |||
import useUpdateIncident from '../../../incidents/hooks/useUpdateIncident' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that you made editing and resolving under the same mutation abstraction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would add a return type to getResolvedOn()
so that it is clear to a user of this function what an "unresolved" result would look like.
fix #2494
Fixes #2494.
Changes proposed in this pull request:
1a. department
1b. category
1c. category item
1d. description
1e. incident reported to
1f. patient impacted