formulae_dependents: build more dependents from source #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this change makes sense then I'll probably wait until #717 has been tested for a bit before merging this. |
If the `--build-dependents-from-source` flag is passed, then all dependents are built from source. This is the current behaviour. We change behaviour in two ways: 1. Build unbottled dependents from source if all its dependencies are either bottled, or were built earlier in the `test-bot` run. 2. Build Linux-only formulae from source too (either with the appropriate flag or when the above condition is true) instead of always skipping source builds on Linux. Building unbottled dependents will be useful for detecting dependents which should be bottled after Homebrew#714. This change should also allow us to clean up a bit of code in the `#dependent_formulae!` method. I've omitted that for now since I have a pending PR (Homebrew#717) which introduces conflicting changes.
On macOS, all formulae are possible `source_dependents`. On Linux, only Linux-only formulae are possible `source_dependents`. From the formulae satisfying the above criteria, we insert only the ones with useable dependencies into the `source_dependents` array. If the `--build-dependents-from-source` flag is passed, then all such dependents are placed into the `source_dependents` array. Otherwise, we select only the ones that are not bottled on the current OS.
carlocab
force-pushed
the
more-source-dependents
branch
from
cd28dee to
c26b3d0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
--build-dependents-from-sourceflag is passed, then alldependents are built from source. This is the current behaviour.
We change behaviour in two ways:
either bottled, or were built earlier in the
test-botrun.appropriate flag or when the above condition is true) instead of
always skipping source builds on Linux.
Building unbottled dependents will be useful for detecting dependents
which should be bottled after #714.
This change should also allow us to clean up a bit of code in the
#dependent_formulae!method. I've omitted that for now since I have apending PR (#717) which introduces conflicting changes.