Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitless: deprecate #177629

Merged
merged 1 commit into from
Jul 17, 2024
Merged

gitless: deprecate #177629

merged 1 commit into from
Jul 17, 2024
+3 −0

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jul 17, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

gitless-vcs/gitless#248

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Jul 17, 2024
@chenrui333 chenrui333 force-pushed the gitless-update branch 2 times, most recently from 0466dbd to d5147bc Compare July 17, 2024 16:43
@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 17, 2024
@branchvincent
Copy link
Member

may be time to deprecate: gitless-vcs/gitless#248

@carlocab
Copy link
Member

We should just use the pygit2 formula here. We have that so that formulae that use pygit2 don't need to be recompiled whenever libgit2 is updated.

@chenrui333
Copy link
Member Author

I think it does not apply for gitless, it does not work with pygit 1.15.x

@chenrui333
gitless: deprecate
35ca52d 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. and removed test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jul 17, 2024
@github-actions github-actions bot added the formula deprecated Formula deprecated label Jul 17, 2024
@chenrui333 chenrui333 changed the title gitless: update to use pygit2 1.15.1 gitless: deprecate Jul 17, 2024
@chenrui333
Copy link
Member Author

mark the formula deprecated

@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 30ed423 Jul 17, 2024
21 checks passed
@BrewTestBot BrewTestBot deleted the gitless-update branch July 17, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@branchvincent branchvincent branchvincent approved these changes

Assignees
No one assigned
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenrui333 @branchvincent @carlocab @BrewTestBot