Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedtls@2: deprecate #162684

Closed

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added legacy Relates to a versioned @ formula formula disabled Formula disabled labels Feb 14, 2024
@chenrui333
Copy link
Member

we can also remove the livecheck per this change

@SMillerDev
Copy link
Member Author

There might still be releases though. It's deprecated, not abandoned.

@chenrui333 chenrui333 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Feb 14, 2024
@SMillerDev
Copy link
Member Author

That's a disappointing amount of dependencies.

  dislocker
    * Dependency 'mbedtls@2' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'mbedtls@2' or deprecate it and all of its dependents.
  hashlink
    * Dependency 'mbedtls@2' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'mbedtls@2' or deprecate it and all of its dependents.
  haxe
    * Dependency 'mbedtls@2' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'mbedtls@2' or deprecate it and all of its dependents.
  julia
    * Dependency 'mbedtls@2' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'mbedtls@2' or deprecate it and all of its dependents.
  neko
    * Dependency 'mbedtls@2' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'mbedtls@2' or deprecate it and all of its dependents.
  shadowsocks-libev
    * Dependency 'mbedtls@2' is deprecated but has un-deprecated dependents. Either
      un-deprecate 'mbedtls@2' or deprecate it and all of its dependents.

@SMillerDev
Copy link
Member Author

Neko seems deprecated itself: HaxeFoundation/neko#287

@SMillerDev
Copy link
Member Author

Dislocker seems abandoned: Aorimn/dislocker#314

@SMillerDev
Copy link
Member Author

Shadowsocks issues are piling up without any answers anywhere: https://github.com/shadowsocks/shadowsocks-libev

@SMillerDev
Copy link
Member Author

Haxe has an issue open: HaxeFoundation/haxe#11195
Julia has one open to replace the dependency: JuliaLang/julia#48799

@cho-m
Copy link
Member

cho-m commented Feb 18, 2024

Dislocker seems abandoned: Aorimn/dislocker#314

They did try switching to mbedtls 3 but it broke Linux builds - revert in Aorimn/dislocker@179c51b


Shadowsocks issues are piling up without any answers anywhere: https://github.com/shadowsocks/shadowsocks-libev

We can probably deprecate it when we feel like (probably at same time as mbedtls@2 unless any activity). Upstream is mainly focusing on shadowsocks-rust. From summary:

  • Bug-fix-only libev port of shadowsocks. Future development moved to shadowsocks-rust

Neko seems deprecated itself: HaxeFoundation/neko#287

The problem is neko is a dependency of haxe. Given our stance on deprecated SSL/TLS libs, we may just have to deprecate them all if they are not off of mbedtls@2 by EOL.


Julia has one open to replace the dependency: JuliaLang/julia#48799

Julia is the biggest issue. There isn't much progress on what they plan to do (e.g. switch to OpenSSL, update to MbedTLS 3, switch to BoringSSL, etc).

I assume they will decide on something before EOL given there are enough maintainers over there.

@theoden8 theoden8 mentioned this pull request Feb 21, 2024
6 tasks
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Mar 10, 2024
@github-actions github-actions bot closed this Mar 17, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula disabled Formula disabled legacy Relates to a versioned @ formula outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants