hashlink 1.12

[tobil4sk]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
  @chenrui333 suggested opening a new one: hashlink 1.12 #100517 (comment)
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

Due to a make issue, we need to fix the PCRE_INCLUDE variable name. On Linux, the rpath as it is set automatically now for the main executables, however, we still need to modify the makefile to set it for the .hdll files. On Mac, we need to still set the rpath so that the hdll libraries can be loaded correctly.

[chenrui333]

Thanks @tobil4sk!!

[chenrui333]

Go for the merge?

[iMichka]

Given there was already some rpath hacking done in the formula and it got just fixed/improved, let's ship this. But ideally we would like to get some of these upstreamed so that we do not need to carry patches around.

[tobil4sk]

Perhaps there would be a better way of handling the load paths for macOS, to avoid the rpath hacks? The hack is needed there only because .hdlls fail to load properly from libexec/lib. It's odd however that this is only an issue for the .hdlls and not the standard hashlink dylib. Perhaps the formula should somehow mark the hdlls as dynamic libraries so homebrew can do whatever it does that gets the dylib working properly? Or perhaps this should be handled in some other way?

For the linux patch, I'll try to do a PR to merge it upstream, however, it still won't come until the next hashlink release which won't be for a while.

[iMichka]

For the linux patch, I'll try to do a PR to merge it upstream, however, it still won't come until the next hashlink release which won't be for a while.

That's fine, the important part it comes in a update in the next months/years, and not in 10 years if no-one submits a patch. We know that release timelines can be quite long, so if we can anticipate things that's always good.

[tobil4sk]

I've opened a PR for the linux patch: HaxeFoundation/hashlink#571

I'm not sure what else to do about the linking on macOS, as I don't know much about dynamic linking practices for homebrew on macOS.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.