Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/unbottled: don't skip non-core formulae #12450

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

scpeters
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Related to Homebrew/homebrew-test-bot#705, and I believe this doesn't conflict with #12325, which also modifies dev-cmd/unbottled. This allows the brew unbottled command to work for formulae in 3rd-party taps.

Before

$ brew unbottled osrf/simulation/gazebo9
==> Populating dependency tree...
==> :catalina bottle status
gazebo9: ready to bottle

After

$ brew unbottled osrf/simulation/gazebo9
==> Populating dependency tree...
==> :catalina bottle status
gazebo9: unbottled deps: ignition-cmake0 ignition-math4

@BrewTestBot
Copy link
Member

Review period will end on 2021-11-19 at 16:29:46 UTC.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Nov 18, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Nov 19, 2021
@MikeMcQuaid
Copy link
Member

Thanks again @scpeters!

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Nov 19, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 7241f8d into Homebrew:master Nov 19, 2021
@scpeters scpeters deleted the unbottled_taps branch November 19, 2021 17:23
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants