Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate Chromeleon program files #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

tmcgrath325
Copy link
Collaborator

I've added a way to generate .pgm files for use with Chromeleon that allow for remote triggering of injections with the autosampler.

I'm not entirely sure that this will be necessary or even convenient. Most often, the .pgm file can be easily manually changed. Since there are a lot of (unorganized) .pgm files on the HPLC laptop, it still might be helpful to have some here.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 67.60% and project coverage change: -6.53 ⚠️

Comparison is base (baaab66) 74.57% compared to head (10e07b7) 68.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   74.57%   68.05%   -6.53%     
==========================================
  Files           1        3       +2     
  Lines          59       72      +13     
==========================================
+ Hits           44       49       +5     
- Misses         15       23       +8     
Impacted Files Coverage Δ
src/Autosampler.jl 100.00% <ø> (+25.42%) ⬆️
src/progfile.jl 0.00% <0.00%> (ø)
src/seqfile.jl 76.19% <76.19%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is everything except the chromeleon stuff just code-movement? Or were there changes?

Not very important, but maybe adding a test of a dummy file would at least ensure the code runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants