feat(Feat/get condition directly): Change the way select and join are retrieved from the GraphQL query. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change from util function to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified logic to get select and join from GraphQL query users provide for better scalability and readability.
as-is
From the graphql query,
get select and join in
ExtendedRepository(src/common/graphql/customExtended.ts)to-be
From the graphql query,
get select and join in interceptor and param decorator.
conclustion
You can find detail codes in interceptor named
UseRepositoryInterceptorand param decorator namedGraphQLQueryToOption