AB#72181 Fix contrast issue on pagination #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a contrast issue on the search results pagination bar.
Fixes AB#72181
Note: The bug ticket mentions contrast issues with the left nav menu items, but upon further manual checks, these are false positives caused by the Wave plugin. The only issue found was with one of the pagination links.
After discussing the left nav menu item issues with Imogen, it was agreed that Wave was not reporting these contrast errors correctly. using the WebAIM Contrast Checker the required tests pass (apart from AAA which is beyond the scope of requirements)...