improve api fetching and fix ui issue (#559)

HimanshuNarware · Oct 10, 2024 · 91b4588 · 91b4588
2 parents 47125c6 + 6565ffb
commit 91b4588
Show file tree

Hide file tree

Showing 6 changed files with 650 additions and 37 deletions.
diff --git a/src/Component/Contributors.jsx b/src/Component/Contributors.jsx
@@ -2,53 +2,55 @@ import React, { useEffect, useState } from 'react';
 import axios from 'axios';
 import './Contributors.css';
 import Preloader from './Preloader';
+import data from '../DB/Contributor.json'
 
 function Contributors() {
   const [contributors, setContributors] = useState([]);
   const [loading, setLoading] = useState(true);
 
-  useEffect(() => {
-    async function fetchContributors() {
-      let allContributors = [];
-      let page = 1;
+  // to improve the fetching speed
+  // useEffect(() => {
+  //   async function fetchContributors() {
+  //     let allContributors = [];
+  //     let page = 1;
 
-      try {
-        while (true) {
-          const response = await axios.get(
-            `https://api.github.com/repos/HimanshuNarware/CareerZunction_Intern/contributors`,
-            {
-              params: {
-                per_page: 100,
-                page,
-              },
-            }
-          );
-          const data = response.data;
-          if (data.length === 0) {
-            break;
-          }
-          allContributors = [...allContributors, ...data];
-          page++;
-        }
-        setContributors(allContributors);
-      } catch (error) {
-        console.error('Error in fetching contributors:', error);
-      } finally {
-        setLoading(false);
-      }
-    }
-    fetchContributors();
-  }, []);
+  //     try {
+  //       while (true) {
+  //         const response = await axios.get(
+  //           `https://api.github.com/repos/HimanshuNarware/CareerZunction_Intern/contributors`,
+  //           {
+  //             params: {
+  //               per_page: 100,
+  //               page,
+  //             },
+  //           }
+  //         );
+  //         const data = response.data;
+  //         if (data.length === 0) {
+  //           break;
+  //         }
+  //         allContributors = [...allContributors, ...data];
+  //         page++;
+  //       }
+  //       setContributors(allContributors);
+  //     } catch (error) {
+  //       console.error('Error in fetching contributors:', error);
+  //     } finally {
+  //       setLoading(false);
+  //     }
+  //   }
+  //   fetchContributors();
+  // }, []);
 
-  if (loading) {
-    return <Preloader />;
-  }
+  // if (loading) {
+  //   return <Preloader />;
+  // }
 
   return (
     <div className="contributors-container">
       <h1 className="contributors-title">Our Contributors</h1>
       <div className="contributors-grid">
-        {contributors.map((contributor) => (
+        {data.map((contributor) => (
           <div key={contributor.id} className="contributor-card">
             <a
               href={contributor.html_url}

diff --git a/src/Component/Documetation/Internship/internpage.css b/src/Component/Documetation/Internship/internpage.css
@@ -320,7 +320,7 @@ body {
 
 @media screen and (max-width:683px) {
     .internBox {
-        margin-top: -120px;
+        margin-top: -20px;
         padding-top: 50px;
 
         display: flex;