Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add book_load warnings, arbitrary-size strings/bytes #397

Merged
merged 14 commits into from
Jun 25, 2024

Conversation

enricozb
Copy link
Contributor

@enricozb enricozb commented Jun 24, 2024

  • Adds support for arbitrarily-sized strings and bytes, which lets READ and WRITE calls work for any size of bytes.
  • book_load now warns if definitions are too large for the respective runtime.
  • removes unused tm parameter from global allocation functions for cuda (does this impact runtime b/c of variable stack sizes)?

Future Work

The rust parser should warn about definition sizes before handing it off to the runtimes.

@enricozb enricozb requested a review from developedby June 24, 2024 12:23
@HigherOrderBot

This comment has been minimized.

src/run.c Outdated Show resolved Hide resolved
src/hvm.c Outdated Show resolved Hide resolved
@HigherOrderBot

This comment has been minimized.

@HigherOrderBot

This comment has been minimized.

@enricozb enricozb requested a review from developedby June 24, 2024 16:51
@HigherOrderBot
Copy link
Collaborator

Perf run for b44023f:

compiled
========

file            runtime         main            (local)       
==============================================================
sort_bitonic    c                        3.96s           3.76s
                cuda                     0.24s           0.14s
--------------------------------------------------------------
sum_rec         c                        1.61s           1.73s
                cuda                     0.14s           0.06s
--------------------------------------------------------------
sum_tree        c                        0.12s           0.12s
                cuda                     0.10s           0.02s
--------------------------------------------------------------
tuples          c                        4.05s           3.31s
                cuda                   timeout         timeout
--------------------------------------------------------------

interpreted
===========

file            runtime         main            (local)       
==============================================================
sort_bitonic    c                        3.79s           3.83s
                cuda                     0.24s           0.15s
                rust                   timeout         timeout
--------------------------------------------------------------
sum_rec         c                        1.78s           1.75s
                cuda                     0.14s           0.06s
                rust                    13.43s          13.48s
--------------------------------------------------------------
sum_tree        c                        0.26s           0.21s
                cuda                     0.09s           0.02s
                rust                     0.83s           0.84s
--------------------------------------------------------------
tuples          c                        2.08s           3.52s
                cuda                   timeout         timeout
                rust                     3.79s           3.80s
--------------------------------------------------------------


@enricozb enricozb merged commit 3b57a21 into main Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants