Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike/improve refresh #2119

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

fix home ui and sharedassembly

1df326a
Select commit
Loading
Failed to load commit list.
Draft

Spike/improve refresh #2119

fix home ui and sharedassembly
1df326a
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jan 23, 2025 in 34s

7 new alerts

New alerts in code changed by this pull request

  • 3 warnings
  • 4 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 77 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'readonly' opportunity Note

Field 'subscribers' can be 'readonly'.

Check warning on line 83 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
x
is useless, since its value is never read.

Check notice on line 107 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Nested 'if' statements can be combined Note

These 'if' statements can be combined.

Check warning on line 104 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
subs
may be null at this access as suggested by
this
null check.

Check notice on line 126 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Nested 'if' statements can be combined Note

These 'if' statements can be combined.

Check warning on line 122 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
subs
may be null at this access as suggested by
this
null check.

Check notice on line 142 in Rdmp.UI/Refreshing/RefreshBus.cs

See this annotation in the file changed.

Code scanning / CodeQL

Nested 'if' statements can be combined Note

These 'if' statements can be combined.