[Refactor] Move isSettingsModalOpen
state from global state to zustand
#4267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added the support to use Zustand to handle state we can gradually migrate from GlobalState context to zustand to improve performance and also cleanup some code (GlobalState was just too big and complex).
This PR does a few things:
SettingsModalWrapper
component (since the state was used insideApp
, even moving the state to zustand was causing a re-render of the whole app)setIsSettingsModalOpen(true, 'log', gameInfo)
we can doopenGameLogsModal(gameInfo)
to hide need of knowing the meaning of those arguments.Use the following Checklist if you have changed something on the Backend or Frontend: