-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust Cairo VM support #104
Open
Okm165
wants to merge
301
commits into
main
Choose a base branch
from
rust-hints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+29,680
−30,718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EVM Syscall handlers
- Introduced new hints for account verification: `HINT_N_ACCOUNTS`, `HINT_N_PROOFS`, `HINT_ACCOUNT_KEY`, and `HINT_GET_MPT_PROOF`. - Added utility functions for handling hexadecimal values in `utils/mod.rs`. - Updated `vars.rs` to include new identifiers related to accounts and proofs. - Created a new module structure for verifiers under `lib/verifiers/evm`. - Enhanced the hint processor to incorporate the new account verification hints.
- Introduced `dry_run_input.rs` and `run_input.rs` to handle new hint processing for HDP dry run and run inputs. - Updated `mod.rs` to include new modules and integrate the new hint functions. - Added utility function `hint_print_task_result` in `utils.rs` for printing task results. - Enhanced hint processing logic to accommodate new hints and ensure proper execution scope management.
…unctions - Added new hints for account verification in `account_verifier.rs`, including batch accounts length, account address retrieval, and proof handling. - Introduced utility functions in `utils/mod.rs` for hex processing and splitting 128-bit integers. - Updated `mod.rs` files to include new modules for better organization of hints and verifiers. - Added new identifiers in `vars.rs` for improved hint referencing. - Refactored existing hint processing logic to integrate new functionalities.
nightly channel
dockerfile update
This reverts commit 622abc9.
codyx
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot of code to review, but overall LGTM
Add server integration tests for dry run, fetch proofs, and sound run…
Keccak syscall support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cairo0
Cairo1
CI/CD
Contract
documentation
Improvements or additions to documentation
enhancement
New feature or request
Rust
server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.