added x cost support #3151
added x cost support #3151
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added X.ai (Grok) model cost configurations and provider integration across the Helicone codebase, enabling cost tracking for X.ai's language models.
- Added cost configurations for 4 Grok models with specific token pricing in
/costs/src/providers/x/index.ts - Integrated X.ai provider pattern
https://api.x.aiin/costs/src/providers/mappings.ts - Warning: Cost files are duplicated across multiple directories despite the "DO NOT EDIT" warning, suggesting potential maintenance issues
- Recommend consolidating cost configurations to single source in
/costsdirectory
5 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| { | ||
| pattern: x, | ||
| provider: "X", | ||
| costs: xCosts, | ||
| }, |
There was a problem hiding this comment.
style: X provider configuration added before 2YFV - consider maintaining alphabetical order with other providers for consistency
| /** | ||
| * | ||
| * DO NOT EDIT THIS FILE UNLESS IT IS IN /costs | ||
| */ |
There was a problem hiding this comment.
logic: This file is in valhalla/jawn/src/packages but the header comment indicates it should only be edited in /costs
| /** | ||
| * | ||
| * DO NOT EDIT THIS FILE UNLESS IT IS IN /costs | ||
| */ |
There was a problem hiding this comment.
logic: This file is in bifrost/packages/cost but the comment states it should only be edited in /costs. This could lead to synchronization issues across the codebase.
| @@ -0,0 +1,49 @@ | |||
| /** | |||
| * | |||
| * DO NOT EDIT THIS FILE UNLESS IT IS IN /costs | |||
There was a problem hiding this comment.
logic: This file should be in /costs directory according to the comment, but is being added to /web/packages/cost instead
No description provided.