Feedback score #2355
Merged
Feedback score #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chitalian
reviewed
Jul 29, 2024
| @@ -602,7 +602,6 @@ export default PlaygroundPage; | |||
| interface PlaygroundPageProps { | |||
| showNewButton?: boolean; | |||
| request?: string; | |||
| showNewButton: boolean; | |||
There was a problem hiding this comment.
@chitalian Removed duplicate showNewButton from @YashKarthik's PR
chitalian
reviewed
Jul 29, 2024
Comment on lines
169
to
174
| public async putScoreIntoClickhouse(newVersion: { | ||
| id: string; | ||
| version: number; | ||
| provider: string; | ||
| score: Score; | ||
| }): Promise<Result<InsertRequestResponseVersioned, string>> { |
There was a problem hiding this comment.
Why don't we just reuse the putScoresIntoClickhouse function here? We are copying the entire implementation
There was a problem hiding this comment.
@chitalian make sense! fixed this
chitalian
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.