Add support for adding concepts to DEATH table #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MoizIqbal97
requested changes
Oct 29, 2024
app/next-client-app/components/scanreports/ScanReportTableUpdateForm.tsx
Outdated
Show resolved
Hide resolved
MoizIqbal97
previously approved these changes
Oct 29, 2024
MoizIqbal97
previously approved these changes
Oct 29, 2024
Jivanam
previously approved these changes
Oct 29, 2024
AndyRae
requested changes
Oct 30, 2024
app/next-client-app/components/scanreports/ScanReportTableUpdateForm.tsx
Outdated
Show resolved
Hide resolved
app/next-client-app/components/scanreports/ScanReportTableUpdateForm.tsx
Outdated
Show resolved
Hide resolved
app/next-client-app/components/scanreports/ScanReportTableUpdateForm.tsx
Outdated
Show resolved
Hide resolved
AndyRae
previously approved these changes
Oct 30, 2024
MoizIqbal97
previously approved these changes
Oct 30, 2024
|
Just to note some feedback
|
AndrewThien
dismissed stale reviews from MoizIqbal97 and AndyRae
via
c3d8bb2
|
the content of the confirmation prompt has been updated now. Please have a look @AndyRae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR added a setting on the ScanReport table's Details page to enable users to make an SR Table a "Death table," where all of the concepts manually added here will be mapped to the OMOP table Death (apart from Race, Gender, and Ethnicity, which will be mapped to the PERSON table to fulfil the OMOP CDM requirement).
When this setting is "ON", the newly added logic in the save_mapping_rules function will map the added concepts to the Death table in OMOP.
For now, this setting, once set, will be permanent. Therefore, a confirmation dialogue will warn users and provide more information when users click the toggle.
The delay duration of the tooltip in ShadCN has also been decreased to enhance UX.
Closes #646
