Fix date_format crash on Windows #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
force-pushed
the
fix/date_format_crash
branch
from
7ae9d5a
to
f4df65e
Compare
On windows, strftime causes a crash if the format is invalid, so we have to do a manual check
tobil4sk
force-pushed
the
fix/date_format_crash
branch
from
f4df65e
to
78155ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
strftimecrashes on Windows if it receives invalid parameters, so we need to manually validate the format parameter to avoid crashing.See:
https://stackoverflow.com/a/64328476
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strftime-wcsftime-strftime-l-wcsftime-l?view=msvc-170#remarks
https://en.cppreference.com/w/c/chrono/strftime