-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display current repository path when using haxelib list
#634
Open
ninjamuffin99
wants to merge
11
commits into
HaxeFoundation:development
Choose a base branch
from
FunkinCrew:list-is-local
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
861edb6
display what scope we are in during `haxelib list` command
ninjamuffin99 0f21754
quick comment to avoid potential further confusion
ninjamuffin99 5cbd705
Quick change to terminology
ninjamuffin99 fec7d32
recurse to look for local path
ninjamuffin99 d65d3b4
use `repository.path` instead of `RepoManager.getPath()`
ninjamuffin99 d9a4b88
find a suggested global path (config + potential default path) instea…
ninjamuffin99 508d461
move the isLocal check to Scope, and remove the arg from the constructor
ninjamuffin99 af54279
some cleanup of unused imports + outdated comment
ninjamuffin99 929017c
supress repo info with --quiet
ninjamuffin99 8a48c0b
use --quiet on the tests to test the old behaviour
ninjamuffin99 5648c5d
revert changes related to GlobalScope + isLocal, since they're irrela…
ninjamuffin99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm,
RepoManager.getGlobalPath()
will throw if there's no global repository setup.This not so pretty hack might not be a good idea..
isLocal
should probably live inRepository
itself, which could also more easily identify local / global cases (might need to reworkget()
a bit there).