[hlc] Use precompiled headers in vs templates #721
Conversation
These are likely to change after recompiling, so it's best to not include these in the precompiled header or they will cause a full recompilation when rebuilding
These are disabled in hlc.h, but when precompiling the header the pragma directives are lost.
|
Tested on shiro's project on my machine. It's better than the current template, and can be useful if we merge; but is still a "big slow down" compared to the 1 file strategy that is currently in use for the project.
(Last week I tested the current template and it takes me 408s (7mins), still worse than this PR but take less time. I suppose the perf is never stable :/) |
|
Comparing a single-file compilation to this doesn't seem particularly fair. If you do that you'd have to take into the account incremental compilation, which should make a huge difference. |
|
Agree. My point is this PR is good and we can merge it. |
|
Yes but we found actually difficult to keep having exactly same output when
going through compiler cache. Maybe it's better now.
Le lun. 28 oct. 2024 à 10:02, Simon Krajewski ***@***.***> a
écrit :
… Comparing a single-file compilation to this doesn't seem particularly
fair. If you do that you'd have to take into the account incremental
compilation, which should make a huge difference.
—
Reply to this email directly, view it on GitHub
<#721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHZXQD4KK2KUVYLYZN5AVLZ5XVQLAVCNFSM6AAAAABQTV4HX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBQHEZDSNJXGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Instead of having to recompile the headers for each individual source file, the headers are now compiled once for the whole project. This gives a further speed up from ~7 seconds to ~3 seconds.