Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI. #623

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Conversation

Apprentice-Alchemist
Copy link
Contributor

  • bump CI runners to supported versions
  • bump HL version in CMakeLists.txt
  • remove the codesigning step for macOS binaries, it fails on the macos-11 runner for some reason and it's useless anyway given that the certificate is generated on each run and not distributed.
  • drop 32-bit Linux CI, for some reason it doesn't work on the 20.04 runner anymore, and it's not like anyone still uses 32-bit-only Linux
  • bump versions of actions/checkout, etc, this fixes some warnings about node versions

closes #597, closes #583, closes #566, closes #538, closes #537

Codesigning fails for some reason on macos-11 runners and anyway,
signing with some randomly generated certificate that doesn't get distributed is pointless.
For some reason 32-bit Linux CI is broken with the 20.04 runner.
@Simn Simn merged commit 20c1e14 into HaxeFoundation:master Sep 21, 2023
9 checks passed
RandomityGuy pushed a commit to RandomityGuy/hashlink that referenced this pull request Jun 1, 2024
* Bump CI runners to Ubuntu 20.04 and macOS 11.

* Bump HL version in CMakeLists.txt

* Don't codesign macOS binaries.

Codesigning fails for some reason on macos-11 runners and anyway,
signing with some randomly generated certificate that doesn't get distributed is pointless.

* Drop 32-bit Linux CI.

For some reason 32-bit Linux CI is broken with the 20.04 runner.

* Bump versions of actions/checkout, etc
@Apprentice-Alchemist Apprentice-Alchemist deleted the bugfix/linux-mac-ci branch June 4, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants