Add ids to the public API #1429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianVennen
changed the title
MiniDigger
reviewed
Dec 20, 2024
backend/src/main/java/io/papermc/hangar/db/dao/internal/projects/HangarProjectPagesDAO.java
Outdated
Show resolved
Hide resolved
MiniDigger
reviewed
Dec 20, 2024
...a/io/papermc/hangar/db/dao/internal/table/versions/downloads/ProjectVersionDownloadsDAO.java
Outdated
Show resolved
Hide resolved
MiniDigger
reviewed
Dec 20, 2024
backend/src/main/java/io/papermc/hangar/db/dao/internal/versions/HangarVersionsDAO.java
Outdated
Show resolved
Hide resolved
MiniDigger
reviewed
Dec 20, 2024
backend/src/main/java/io/papermc/hangar/db/dao/v1/ProjectsApiDAO.java
Outdated
Show resolved
Hide resolved
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
MiniDigger
reviewed
Dec 20, 2024
backend/src/main/java/io/papermc/hangar/service/api/VersionsApiService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes IDs for Users, Projects, and Versions on the APIs and accepts them in all endpoints that previously accepted slugs as requested in #1303.
Since version IDs identify a version even without the project being specified, I also added endpoints for that.
The methods implementing the Public API endpoints now accept a UserTable/ProjectTable/ProjectVersionTable object instead of the slug. These are resolved from the slug/id provided in the request path. The Project(Version)Table was already required by the VisibilityVoter for most endpoints and is reused without fetching it from the database twice.
Some queries can also be simplified to remove additional joins that were only used to resolve a project slug. I did that where I noticed it, but I'm sure I've missed some.