Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bright background on navbar icons in dark mode #1400

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Fix bright background on navbar icons in dark mode #1400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
650d813
Fix bright background on navbar icons in dark mode
mdcfe Aug 10, 2024
8f56f33
Merge branch 'staging' into misc/improve-buttons-style
MiniDigger Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/src/components/layout/Header.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,14 @@ function isRecent(date: string): boolean {
</template>
</DropdownButton>
</div>
<button class="flex rounded-md p-2" hover="text-primary-500 bg-primary-0" aria-label="Toogle dark mode" @click="settings.toggleDarkMode()">
<button class="flex rounded-md p-2" hover="text-primary-500 bg-primary-0 dark:(text-white bg-zinc-700)" aria-label="Toogle dark mode" @click="settings.toggleDarkMode()">
<icon-mdi-weather-night v-if="settings.darkMode" class="text-[1.2em]"></icon-mdi-weather-night>
<icon-mdi-white-balance-sunny v-else class="text-[1.2em]"></icon-mdi-white-balance-sunny>
</button>
<div v-if="authStore.user">
<Popper placement="bottom-end">
<button
class="flex items-center gap-2 rounded-md p-2 hover:(text-primary-500 bg-primary-0)"
class="flex items-center gap-2 rounded-md p-2 hover:(text-primary-500 bg-primary-0 dark:(text-white bg-zinc-700))"
aria-label="Notifications"
@click="updateNotifications"
>
Expand Down Expand Up @@ -304,7 +304,7 @@ function isRecent(date: string): boolean {
<!-- Profile dropdown -->
<div v-if="authStore.user">
<Popper placement="bottom-end">
<button class="flex items-center gap-2 rounded-md p-2 hover:(text-primary-500 bg-primary-0)" @click="updateNavData">
<button class="flex items-center gap-2 rounded-md p-2 hover:(text-primary-500 bg-primary-0 dark:(text-white bg-zinc-700))" @click="updateNavData">
<UserAvatar :username="authStore.user.name" :avatar-url="authStore.user.avatarUrl" size="xs" :disable-link="true" />
{{ authStore.user.name }}
</button>
Expand Down Expand Up @@ -345,11 +345,11 @@ function isRecent(date: string): boolean {

<!-- Login/register buttons -->
<div v-else class="flex gap-2">
<NuxtLink class="flex items-center rounded-md p-2 hover:(text-primary-500 bg-primary-0)" :to="auth.loginUrl(route.fullPath)" rel="nofollow">
<NuxtLink class="flex items-center rounded-md p-2 hover:(text-primary-500 bg-primary-0 dark:(text-white bg-zinc-700))" :to="auth.loginUrl(route.fullPath)" rel="nofollow">
<icon-mdi-key-outline class="mr-1 flex-shrink-0 text-[1.2em]" />
{{ t("nav.login") }}
</NuxtLink>
<NuxtLink class="flex items-center rounded-md p-2 hover:(text-primary-500 bg-primary-0)" :to="auth.signupUrl(route.fullPath)">
<NuxtLink class="flex items-center rounded-md p-2 hover:(text-primary-500 bg-primary-0 dark:(text-white bg-zinc-700))" :to="auth.signupUrl(route.fullPath)">
<icon-mdi-clipboard-outline class="mr-1 flex-shrink-0 text-[1.2em]" />
{{ t("nav.signup") }}
</NuxtLink>
Expand Down
Loading