Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StraightLineTool: don't add 1 to even-numbered widths #620

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

dsizzle
Copy link
Collaborator

@dsizzle dsizzle commented Sep 16, 2023

Addressed the "straight line" part of #618

For some strange reason the width had 1 added to it if it was an even number? No idea why but it seems to work fine without that.

@humdingerb
Copy link
Member

Works worth width set in the straight line tool setup. If you "Use current brush" though you still get the same as described in #618::

"Width" = 1: shows as 1 pixel width/height
"Width" = 2: shows as 3 pixel width/height
"Width" = 3: shows as 3 pixel width/height
"Width" = 4: shows as 5 pixel width/height
"Width" = 5: shows as 5 pixel width/height
"Width" = 6: shows as 7 pixel width/height

The same happens with "Use current brush" for the freehand tool.

@dsizzle
Copy link
Collaborator Author

dsizzle commented Sep 16, 2023

You need to pull #619 to get the right behavior for the current brush.

this PR only fixes the straight line tool and needs to be merged in concert with #619

@humdingerb
Copy link
Member

Oops, sorry, I thought #619 was merged before you created this PR. All works as intended with #619 added.

@dsizzle dsizzle merged commit 47bd27b into HaikuArchives:master Sep 16, 2023
1 of 2 checks passed
@dsizzle
Copy link
Collaborator Author

dsizzle commented Sep 16, 2023

yay, merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants