Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageView/Image: Moved layer data copying to where layer structure is rebuilt #600

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

dsizzle
Copy link
Collaborator

@dsizzle dsizzle commented Aug 26, 2023

This is a better fix for #240 I believe. It fixes the undo-redo-undo-redo of deleted layers that didn't quite work before:

  1. create a layer
  2. rename it
  3. delete it
  4. undo delete layer, layer reappears with correct name
  5. redo delete layer
  6. undo delete layer, layer reappears with correct name <- this didn't work before this fix. Now you can undo and redo and the layer properties come back

Still missing from #240 is layer re-ordering, but at least I think this works better.

@humdingerb
Copy link
Member

Works indeed!

@humdingerb humdingerb merged commit d18e175 into HaikuArchives:master Aug 26, 2023
0 of 2 checks passed
@dsizzle dsizzle deleted the undo-meta-redo branch August 30, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants