Skip to content

Commit

Permalink
Merge pull request #836 from HEPData/drop-python3.8
Browse files Browse the repository at this point in the history
Drop support for Python 3.8
  • Loading branch information
GraemeWatt authored Nov 1, 2024
2 parents fe5156f + d05728a commit 2d1533a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ jobs:
matrix:
postgres-version: [ 14 ]
os-version: [ '2.11.0' ]
python-version: [ '3.8', '3.9' ]
exclude:
- python-version: ${{ github.event.act && '3.8' }}
python-version: [ '3.9' ]

# Service containers to run with `runner-job`
services:
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Before you submit a pull request, check that it meets these guidelines:
1. The pull request should include tests and must not decrease test coverage.
2. If the pull request adds functionality, the docs should be updated. Put
your new functionality into a function with a docstring.
3. The pull request should work for Python 3.8 and 3.9. Check
3. The pull request should work for Python 3.9. Check
https://github.com/HEPData/hepdata/actions?query=event%3Apull_request
and make sure that the tests pass. Sometimes there are temporary failures,
for example, due to unavailability of an external service or the test infrastructure.
Expand Down
4 changes: 2 additions & 2 deletions INSTALL.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Running services locally
Prerequisites
=============

HEPData runs with Python 3.8 or 3.9. It also uses several services, which you will need to install before running HEPData.
HEPData runs with Python 3.9. It also uses several services, which you will need to install before running HEPData.

These services can be installed using the relevant package manager for your system,
for example, using ``yum`` or ``apt-get`` for Linux or ``brew`` for macOS:
Expand Down Expand Up @@ -84,7 +84,7 @@ Installation

Python
------
The HEPData code is only compatible with Python 3.8 or 3.9 (not Python 2 or other 3.x versions). We recommend Python 3.9.
The HEPData code is only compatible with Python 3.9 (not Python 2 or other 3.x versions).

First install all requirements in a Python virtual environment.
(Use `virtualenv <https://virtualenv.pypa.io/en/stable/installation.html>`_ or
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,8 @@
'Topic :: Internet :: WWW/HTTP :: Dynamic Content',
'Topic :: Software Development :: Libraries :: Python Modules',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Development Status :: Production',
],
python_requires='>=3.8, <3.10',
python_requires='>=3.9, <3.10',
)

0 comments on commit 2d1533a

Please sign in to comment.