Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change glideclient advertisement logic #484

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

BrunoCoimbra
Copy link
Contributor

This PR changes the glideclient classads advertisement logic to address #446.
Now, the GlideinWMS module of Decision Engine will keep refreshing glideclients while Glideins associated with them are present.

Copy link
Contributor

@StevenCTimm StevenCTimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my knowledge of the code system it appears that this will have the intended effect and solve the problem in !446
I leave the review of the actual mechanics of the code to others.

@pep8speaks
Copy link

Hello @BrunoCoimbra! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1522:24: F821 undefined name 'glideids_to_advertize'

@mambelli mambelli merged commit cb19a5b into HEPCloud:master Dec 14, 2023
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants