Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_title #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add get_title #142

wants to merge 1 commit into from

Conversation

amckenzie132
Copy link

#141 implements get_title

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@konstunn
Copy link
Contributor

konstunn commented Jan 7, 2022

Why is it not merged?

@dimaqq
Copy link
Contributor

dimaqq commented Jan 7, 2022

That’s a good question…
@ojii ?

(I think I don’t have permission to merge in this repo, not that I’m necessarily following it, as I’ve recently switched jobs)

@alexh-sauce
Copy link

@ojii can this get merged?

@douglasdcm
Copy link

douglasdcm commented May 17, 2023

Hi, is this repository accepting new MRs? I noticed this is open since 2021. I'd like to contribute, but just if it alive.

@ojii
Copy link
Contributor

ojii commented May 18, 2023

Hi, is this repository accepting new MRs? I noticed this is open since 2021. I'd like to contribute, but just if it alive.

Basically there's a few issues with this repo which make me reluctant to accept too many PRs:

  1. When we made this project, we needed it to solve a very specific use case: Running automated tests in an asyncio context with IE11 on a remote webdriver. This is still our main use-case and the library as it is solves this use case.
  2. Testing is very hard and unreliable. This is probably the main reason I am reluctant to just merge stuff, I just don't trust our test suite/CI setup.
  3. Some early API design decisions were a mistake, making changes harder.

So it's hard to confidently make changes, and the library does what it needs to do for us, as a result I invest little to no time to maintain this.

If someone wants to fully take over maintenance of this project, let's have a chat. There's also a fork button on github and the project is licensed very liberally...

@douglasdcm
Copy link

Hi @ojii thanks a lot for the quick answer. I got what you said. No worries. My use case for an asynchronous WebDriver is not so hard. I think I can build a small library from my side.

@douglasdcm
Copy link

Hi, @ojii I created a simple library to run synchronous and asynchronous requests to WebDrivers. If you have time, I'd like your opinion about. https://pypi.org/project/caqui/
Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants