Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/member] 회원 탈퇴 기능 구현 #93

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[Feat/member] 회원 탈퇴 기능 구현 #93

merged 2 commits into from
Nov 30, 2023

Conversation

onetuks
Copy link
Contributor

@onetuks onetuks commented Nov 30, 2023

No description provided.

@onetuks onetuks added the enhancement New feature or request label Nov 30, 2023
@onetuks onetuks self-assigned this Nov 30, 2023
Copy link
Contributor

@wonu606 wonu606 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!😁

하루만에 회원 탈퇴 기능 완성이라니..
조금 수정할 부분이 있는 것 같습니다❣️

Comment on lines +22 to +23
@Query("select att.id from AcademyTimeTemplate att where att.childId in :childIds")
List<Long> findByChildIds(List<Long> childIds);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List<AcademyTimeTemplate> findByChildIdIn(List<Long> childIds);

이렇게도 사용할 수 있지 않나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 그러네요
in 키워드가 없을 수가 없는뎅..
그래도 확실하게 쿼리문으로 해결해보고 싶습니다!!

@@ -73,6 +73,10 @@ public void delete(ChildDeleteParam param) {
member.removeChild(param.childId());
}

public void removeChild(long memberId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transactional 필요할 것 같습니다!

@onetuks onetuks merged commit 564b406 into develop Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants