[Features/review] 리뷰 도메인 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wonu606
reviewed
Nov 4, 2023
Comment on lines
9
to
13
| @NotNull boolean kindness, | ||
| @NotNull boolean cheapFee, | ||
| @NotNull boolean goodFacility, | ||
| @NotNull boolean goodManagement, | ||
| @NotNull boolean lovelyTeaching |
There was a problem hiding this comment.
boolean이라 @NotNull 처리 안해주셔도 될 것 같습니다!
There was a problem hiding this comment.
아 그러네요
primitive 타입이니까 애초에 null 값이 들어가지 않겠네요!
wonu606
reviewed
Nov 4, 2023
Comment on lines
48
to
56
| private static void validateThreeReviewLimit(final Map<ReviewType, Boolean> map) { | ||
| long count = map.values().stream() | ||
| .filter(value -> value) | ||
| .count(); | ||
|
|
||
| if (count > 3) { | ||
| throw new ReviewException("리뷰는 3개까지만 가능합니다."); | ||
| } | ||
| } |
There was a problem hiding this comment.
매직 넘버 3을 상수로 바꾸겠습니다!
wonu606
reviewed
Nov 4, 2023
| @MemberId Long memberId, | ||
| @RequestParam Long academyId | ||
| ) { | ||
| ReviewableResult result = reviewService.isReviewableToAcademy(memberId, academyId); |
There was a problem hiding this comment.
is 라서 boolean만을 return 할 것 같은데, result를 리턴해서 조금 어색한 것 같습니다!
There was a problem hiding this comment.
getReviewableToAcademy 로 바꾸겠습니다!
wonu606
previously approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기능 구현
필요 사항