[Feat/member] 회원 탈퇴 시 로컬 캐시 제거 #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byeolhaha
approved these changes
Dec 4, 2023
| ) { | ||
| memberFacade.removeMember(memberId); | ||
| String appToken = JwtHeaderUtil.getAccessToken(request); | ||
| AuthToken authToken = authTokenProvider.convertAuthToken(appToken); |
There was a problem hiding this comment.
controller에서 AuthToken은 만드는 것보다는 내부에서 생성하는 거 어떻게 생각하시나요?
최대한 controller는 전달의 역할만 하는 것이 좋다고 생각해요
| } | ||
|
|
||
| @Transactional | ||
| public void removeMember(final long memberId) { | ||
| public void removeMember(final long memberId, final AuthToken authToken) { | ||
| List<Long> childIds = childService.findByMemberId(memberId).children() | ||
| .stream() | ||
| .map(ChildFindResult::childId) |
There was a problem hiding this comment.
childService에서 child Id 리스트 자체를 넘겨주는 방법은 어떠신가요?
필요한 것은 childId 하나인데 불필요한 여러 칼럼이 불러와지는 것으로 보입니다.
꼭 필요한 칼럼만 불러와 지는 것이 더 명확할 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secede메소드