[로그인, 로그아웃] 글로벌 캐시Redis에서 로컬 캐시로 변경 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onetuks
approved these changes
Dec 3, 2023
Comment on lines
+9
to
+13
| @Repository | ||
| public class LogoutTokenRepository { | ||
|
|
||
| private final JwtTokenCacheConfig jwtTokenCacheConfig; | ||
| private final Cache<String, String> logoutCache; |
There was a problem hiding this comment.
로그아웃 토근도 따로 있나보네요??
JWT 랑 같은 형식인가요?
There was a problem hiding this comment.
오 맞습니다.
로그아웃 했지만 만료되지 않은 AccessToken으로 요청을 보낼 위험이 있어서
아직 만료기간이 남은 로그아웃 한 AccessToken을 보관하고 있습니다.
JWT와 같은 형식입니다.
Comment on lines
-71
to
+72
| refreshTokenRepository.save(new JwtToken(refreshToken.getToken(), newAccessToken.getToken())); | ||
| refreshTokenRepository.save(newAccessToken.getToken(), refreshToken.getToken()); |
There was a problem hiding this comment.
이건 리프레시로 새로 발급하는 거고 , 아래는 아예 모든 토큰을 새로 만드는 거군요!!
Comment on lines
115
to
117
| // Netty/Resolver/DNS/Native/MacOS | ||
| implementation("io.netty:netty-resolver-dns-native-macos:4.1.79.Final:osx-aarch_64") | ||
|
|
There was a problem hiding this comment.
이건 develop에서 충돌 해결하면서 추가되었습니다 🌸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현