Merge pull request #32 from Guzzing/features/review

Fix: 리뷰 항목 누락 건 추가
Guzzing · Nov 8, 2023 · 69c57f0 · 69c57f0
2 parents 530af8d + fbfab9d
commit 69c57f0
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 7 deletions.
diff --git a/...java/org/guzzing/studayserver/domain/review/controller/dto/request/ReviewPostRequest.java b/...java/org/guzzing/studayserver/domain/review/controller/dto/request/ReviewPostRequest.java
@@ -9,7 +9,8 @@ public record ReviewPostRequest(
         boolean cheapFee,
         boolean goodFacility,
         boolean goodManagement,
-        boolean lovelyTeaching
+        boolean lovelyTeaching,
+        boolean shuttleAvailability
 ) {
 
     public static ReviewPostParam to(final Long memberId, final ReviewPostRequest request) {
@@ -20,7 +21,8 @@ public static ReviewPostParam to(final Long memberId, final ReviewPostRequest re
                 request.cheapFee(),
                 request.goodFacility(),
                 request.goodManagement(),
-                request.lovelyTeaching()
+                request.lovelyTeaching(),
+                request.shuttleAvailability()
         );
     }
 

diff --git a/src/main/java/org/guzzing/studayserver/domain/review/model/ReviewType.java b/src/main/java/org/guzzing/studayserver/domain/review/model/ReviewType.java
@@ -14,7 +14,8 @@ public enum ReviewType {
     GOOD_FACILITY,
     CHEAP_FEE,
     GOOD_MANAGEMENT,
-    LOVELY_TEACHING;
+    LOVELY_TEACHING,
+    SHUTTLE_AVAILABILITY;
 
     private static final int MAX_REVIEW_COUNT = 3;
 
@@ -26,6 +27,7 @@ public static Map<ReviewType, Boolean> getSelectedReviewMap(final ReviewPostPara
         selectedReviewMap.put(ReviewType.CHEAP_FEE, reviewPostParam.cheapFee());
         selectedReviewMap.put(ReviewType.GOOD_MANAGEMENT, reviewPostParam.goodManagement());
         selectedReviewMap.put(ReviewType.LOVELY_TEACHING, reviewPostParam.lovelyTeaching());
+        selectedReviewMap.put(ReviewType.SHUTTLE_AVAILABILITY, reviewPostParam.shuttleAvailability());
 
         validateThreeReviewLimit(selectedReviewMap);
 

diff --git a/...main/java/org/guzzing/studayserver/domain/review/service/dto/request/ReviewPostParam.java b/...main/java/org/guzzing/studayserver/domain/review/service/dto/request/ReviewPostParam.java
@@ -7,7 +7,8 @@ public record ReviewPostParam(
         boolean cheapFee,
         boolean goodFacility,
         boolean goodManagement,
-        boolean lovelyTeaching
+        boolean lovelyTeaching,
+        boolean shuttleAvailability
 ) {
 
 }
diff --git a/src/test/java/org/guzzing/studayserver/domain/like/service/LikeServiceTest.java b/src/test/java/org/guzzing/studayserver/domain/like/service/LikeServiceTest.java
@@ -22,7 +22,7 @@
 import org.springframework.test.context.ActiveProfiles;
 import org.springframework.transaction.annotation.Transactional;
 
-@ActiveProfiles(profiles = {"dev", "oauth"})
+@ActiveProfiles(profiles = {"dev", "oauth", "test"})
 @SpringBootTest
 @Transactional
 class LikeServiceTest {

diff --git a/...test/java/org/guzzing/studayserver/domain/review/controller/ReviewRestControllerTest.java b/...test/java/org/guzzing/studayserver/domain/review/controller/ReviewRestControllerTest.java
@@ -100,7 +100,8 @@ void registerReview_Success() throws Exception {
                                 fieldWithPath("cheapFee").type(BOOLEAN).description("수강료가 싸요 리뷰 선택 여부"),
                                 fieldWithPath("goodFacility").type(BOOLEAN).description("시설이 좋아요 리뷰 선택 여부"),
                                 fieldWithPath("goodManagement").type(BOOLEAN).description("관리가 좋아요 리뷰 선택 여부"),
-                                fieldWithPath("lovelyTeaching").type(BOOLEAN).description("가르침이 사랑스러워요 리뷰 선택 여부")
+                                fieldWithPath("lovelyTeaching").type(BOOLEAN).description("가르침이 사랑스러워요 리뷰 선택 여부"),
+                                fieldWithPath("shuttleAvailability").type(BOOLEAN).description("셔틀을 운행해요 리뷰 선택 여부")
                         ),
                         responseFields(
                                 fieldWithPath("reviewId").type(NUMBER).description("리뷰 아이디"),

diff --git a/src/test/java/org/guzzing/studayserver/testutil/fixture/ReviewFixture.java b/src/test/java/org/guzzing/studayserver/testutil/fixture/ReviewFixture.java
@@ -5,6 +5,7 @@
 import static org.guzzing.studayserver.domain.review.model.ReviewType.GOOD_MANAGEMENT;
 import static org.guzzing.studayserver.domain.review.model.ReviewType.KINDNESS;
 import static org.guzzing.studayserver.domain.review.model.ReviewType.LOVELY_TEACHING;
+import static org.guzzing.studayserver.domain.review.model.ReviewType.SHUTTLE_AVAILABILITY;
 
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -32,7 +33,8 @@ public static ReviewPostRequest makeReviewPostRequest(boolean isValid) {
                 reviewMap.get(CHEAP_FEE),
                 reviewMap.get(GOOD_FACILITY),
                 reviewMap.get(GOOD_MANAGEMENT),
-                reviewMap.get(LOVELY_TEACHING));
+                reviewMap.get(LOVELY_TEACHING),
+                reviewMap.get(SHUTTLE_AVAILABILITY));
     }
 
     public static Map<ReviewType, Boolean> makeInvalidReviewMap() {
@@ -43,6 +45,7 @@ public static Map<ReviewType, Boolean> makeInvalidReviewMap() {
         invalidReviewMap.put(GOOD_FACILITY, true);
         invalidReviewMap.put(GOOD_MANAGEMENT, false);
         invalidReviewMap.put(LOVELY_TEACHING, true);
+        invalidReviewMap.put(SHUTTLE_AVAILABILITY, false);
 
         return invalidReviewMap;
     }
@@ -55,6 +58,7 @@ public static Map<ReviewType, Boolean> makeValidReviewMap() {
         validReviewMap.put(GOOD_FACILITY, false);
         validReviewMap.put(GOOD_MANAGEMENT, false);
         validReviewMap.put(LOVELY_TEACHING, true);
+        validReviewMap.put(SHUTTLE_AVAILABILITY, false);
 
         return validReviewMap;
     }