Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump csharpier from 0.30.3 to 0.30.4 #47

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 30, 2024

Bumps csharpier from 0.30.3 to 0.30.4.

Release notes

Sourced from csharpier's releases.

0.30.4

What's Changed

Formatting deletes unsafe modifier #1416

Formatting a using directive with an unsafe modifier resulted in the lose of the unsafe keyword

// input & expected output
using unsafe NvapiQueryInterface = delegate* unmanaged[Cdecl]<uint, nint>;
// 0.30.3
using NvapiQueryInterface = delegate* unmanaged[Cdecl]<uint, nint>;

CSharpier keeps adding a newline every time a file is formatted #1408

In some cases if a file ended with a comment, CSharpier would add a new extra blank line above the comment each time it formatted the file

// input & expected outpet
using System;
namespace MyCompany.MyNamespace;
// Comment block
// 0.30.3
using System;
namespace MyCompany.MyNamespace;
// Comment block

Full Changelog: belav/csharpier@0.30.3...0.30.4

Changelog

Sourced from csharpier's changelog.

# 0.30.4

What's Changed

Formatting deletes unsafe modifier #1416

Formatting a using directive with an unsafe modifier resulted in the lose of the unsafe keyword

// input & expected output
using unsafe NvapiQueryInterface = delegate* unmanaged[Cdecl]<uint, nint>;
// 0.30.3
using NvapiQueryInterface = delegate* unmanaged[Cdecl]<uint, nint>;

CSharpier keeps adding a newline every time a file is formatted #1408

In some cases if a file ended with a comment, CSharpier would add a new extra blank line above the comment each time it formatted the file

// input & expected outpet
using System;
namespace MyCompany.MyNamespace;
// Comment block
// 0.30.3
using System;
namespace MyCompany.MyNamespace;
// Comment block

Full Changelog: belav/csharpier@0.30.3...0.30.4

Commits
  • 064d35f Releasing 0.30.4 (#1420)
  • cd618ac Fixing a bug introduced by one of the fixes (#1421)
  • 3b88bee Fixing issue with losing unsafe keyword on using statement (#1417)
  • e3b5efb Figuring out a way to prevent the extra line before a file ending comment (#1...
  • baa3138 Some refactoring that was in the csproj branch but didn't really belng there ...
  • bfedce4 Ignoring files in "" when reporting that csharpier needs to be insta… (#1412)
  • 6d285fe Avoid eagerly warming csharpier, doesn't seem to be a good way to delay that ...
  • 5cf6488 Fixing bug for VS2022 options page not working when no solution open. (#1410)
  • 3c6f9ce Adding an option to disable diagnostics for unformatted code. (#1404)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Update CSharpier to version 0.30.4.

Bug Fixes:

  • Fix formatting of using directives with unsafe modifiers.
  • Fix extra newline being added above comments when formatting files.

Bumps [csharpier](https://github.com/belav/csharpier) from 0.30.3 to 0.30.4.
- [Release notes](https://github.com/belav/csharpier/releases)
- [Changelog](https://github.com/belav/csharpier/blob/main/CHANGELOG.md)
- [Commits](belav/csharpier@0.30.3...0.30.4)

---
updated-dependencies:
- dependency-name: csharpier
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 30, 2024

The following labels could not be found: nuget, .NET, packages, dependencies.

Copy link

korbit-ai bot commented Dec 30, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

semanticdiff-com bot commented Dec 30, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  .config/dotnet-tools.json  0% smaller

Copy link

pr-code-reviewer bot commented Dec 30, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior.

  1. /.config/dotnet-tools.json - Upgrading csharpier from version "0.30.3" to "0.30.4" without testing the integration can lead to unexpected behavior if there are breaking changes in the new version. It is essential to verify the compatibility of the new version with existing code before upgrading.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency.

  1. /.config/dotnet-tools.json - Consider using a versioning strategy that locks dependencies to specific minor or patch versions (e.g., using "0.30.4" or "0.30.*") to maintain better control over updates and avoid spontaneous breaking changes in production environments.

Copy link

instapr bot commented Dec 30, 2024

Feedback

  • Version of csharpier has been successfully updated from 0.30.3 to 0.30.4.
  • Code change looks good.

Overall, the PR is ready for merge. Great job! 👍

Copy link

deepsource-io bot commented Dec 30, 2024

Here's the code health analysis summary for commits 0a70926..08aeaf3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource C# LogoC#✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateC#
Branch Coverage100%100%
Composite Coverage0%0%
Line Coverage0%0%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

sourcery-ai bot commented Dec 30, 2024

Reviewer's Guide by Sourcery

This PR bumps the version of csharpier from 0.30.3 to 0.30.4. This addresses two bugs: one where the "unsafe" keyword was removed from using directives during formatting, and another where an extra newline was added above comments at the end of files. The upgrade also includes other minor fixes and improvements.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgrade the csharpier library from version 0.30.3 to 0.30.4.
  • Update the version number for csharpier in the dotnet-tools.json file from "0.30.3" to "0.30.4".
.config/dotnet-tools.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

Copy link

Infisical secrets check: ✅ No secrets leaked!

💻 Scan logs
10:11PM INF scanning for exposed secrets...
10:11PM INF 32 commits scanned.
10:11PM INF scan completed in 65.9ms
10:11PM INF no leaks found

@guibranco guibranco enabled auto-merge (squash) December 30, 2024 22:12
@gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Dec 30, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Automated processes or integrations label Dec 30, 2024
@guibranco
Copy link
Member

@dependabot squash and merge

@guibranco
Copy link
Member

@coderabbitai review

@guibranco guibranco disabled auto-merge December 31, 2024 02:49
@guibranco guibranco merged commit c640f2b into main Dec 31, 2024
17 checks passed
@guibranco guibranco deleted the dependabot/nuget/csharpier-0.30.4 branch December 31, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) 🤖 bot Automated processes or integrations size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant