Fix a bug whereby null was wrongly recognised as of type object

GuccioGucci · May 2, 2024 · 5f8968c · 5f8968c
1 parent b08c661
commit 5f8968c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/isValid.ts b/src/isValid.ts
@@ -53,7 +53,7 @@ function isValidLiteral(schema: LiteralSchema, value: any): boolean {
 }
 
 function isValidObject(schema: ObjectSchema, value: any): boolean {
-  if (typeof value !== 'object') {
+  if (typeOf(value) !== 'object') {
     return false
   }
 

diff --git a/src/object.test.ts b/src/object.test.ts
@@ -94,4 +94,12 @@ test(`object marks optional fields by ending keys with ?`, function () {
   assert.is(res3, true)
 })
 
+test(`null is not an object`, function () {
+  const obj = object({})
+
+  const res = isValid(obj, null)
+
+  assert.is(res, false)
+})
+
 test.run()