fix(#1157): update request rate limiting #1223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clm-Roig
force-pushed
the
fix/1157_rate_limits
branch
from
68a7685
to
bb2bf99
Compare
Clm-Roig
force-pushed
the
fix/1157_rate_limits
branch
from
bb2bf99
to
867f8fe
Compare
Clm-Roig
force-pushed
the
fix/1157_rate_limits
branch
from
867f8fe
to
2e601d5
Compare
Clm-Roig
force-pushed
the
fix/1157_rate_limits
branch
from
2e601d5
to
f94c063
Compare
Clm-Roig
force-pushed
the
fix/1157_rate_limits
branch
from
f94c063
to
5cf6649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1157
A lot of code is copy / pasted. I tried to refactor it but I'm not satisfied enough. How can I improve it ?
EDIT: Ok I found a way. The package allows the max (number of requests) value to be computed using a function (instead of a number). I will deduce the rate limiting depending on the user groups.