-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: unify the option names across all components #5457
base: main
Are you sure you want to change the base?
refactor!: unify the option names across all components #5457
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need also make sure the cli interface works and is changed as expected
config/frontend.example.toml
Outdated
bind_addr = "127.0.0.1:4001" | ||
## The address advertised to the metasrv, | ||
## and used for connections from outside the host | ||
hostname = "127.0.0.1:4001" | ||
server_addr = "127.0.0.1:4001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sugg:
- About default value for
server_addr
, like "default to bind_addr" - Describe the intended use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolved in 7364280
7364280
to
d2eb83f
Compare
Yes, the CLI part will be handled in the next commit. |
94959fd
to
597ca59
Compare
597ca59
to
e0b4b21
Compare
8ff8174
to
ee5525f
Compare
ee5525f
to
6809c10
Compare
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
As the title said
PR Checklist
Close #5418