feat(to_unixtime): add initial implementation #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etolbakov
commented
Mar 17, 2023
etolbakov
commented
Mar 17, 2023
|
@waynexia |
etolbakov
commented
Mar 20, 2023
waynexia
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Great job! This patch generally looks good to me. Do you mind also adding some cases in our sqlness suite? Maybe a new file under common/select dir.
Codecov Report
@@ Coverage Diff @@
## develop #1186 +/- ##
===========================================
- Coverage 85.14% 84.72% -0.42%
===========================================
Files 485 495 +10
Lines 71903 72593 +690
===========================================
+ Hits 61223 61508 +285
- Misses 10680 11085 +405 |
|
@waynexia |
waynexia
approved these changes
Mar 21, 2023
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* feat(to_unixtime): add initial implementation * feat(to_unixtime): use Timestamp for conversion * feat(to_unixtime): implement conversion to Result<VectorRef> * feat(to_unixtime): make unit test pass * feat(to_unixtime): preserve None for invalid timestamps * feat(to_unixtime): address code review suggestions * feat(to_unixtime): add an sqlness test * feat(to_unixtime): adjust the assertion for the sqlness test * Update tests/cases/standalone/common/select/dummy.sql --------- Co-authored-by: Ruihang Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The feature adds a new UDF
to_unixtime()for conversions from a timestamp in RFC3339 format to a Unix timestamp.Checklist
Refer to a related PR or issue link (optional)
#1103