chore(from_unixtime): remove UDF from_unixtime #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waynexia |
killme2008
reviewed
Mar 15, 2023
waynexia
approved these changes
Mar 15, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1179 +/- ##
===========================================
+ Coverage 85.20% 85.25% +0.04%
===========================================
Files 485 484 -1
Lines 71588 71690 +102
===========================================
+ Hits 61000 61119 +119
+ Misses 10588 10571 -17 |
|
for some reason |
auto-merge was automatically disabled
March 15, 2023 08:05
Head branch was pushed to by a user without write access
|
@waynexia @killme2008 |
|
Thanks @etolbakov |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* chore(from_unixtime): remove UDF from_unixtime * chore(from_unixtime): restore timestamp.rs for further usage * chore(from_unixtime): address fmt issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
replace our
from_unixtime()with DataFusion function.Checklist
Refer to a related PR or issue link (optional)
#1103