Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing frames from pipes in structure won't cause multiblock structure invalidization #2582

Open
MCTian-mi opened this issue Aug 11, 2024 · 1 comment · May be fixed by #2304
Open

Removing frames from pipes in structure won't cause multiblock structure invalidization #2582

MCTian-mi opened this issue Aug 11, 2024 · 1 comment · May be fixed by #2304
Labels
status: unverified Issue is unverified

Comments

@MCTian-mi
Copy link
Contributor

GregTech CEu Version

2.8.10

Modpack Used

No response

Addons Installed

No response

Environment

Singleplayer

New Worlds

Yes

Cross-Mod Interaction

No

Expected Behavior

Multiblocks should invalidiate themselves when the frames from pipes in their structure.

Actual Behavior

No they don't.

Steps to Reproduce

  1. Build a multiblock with frames in their structure (using frames() predicate in code) using framed pipes.
  2. The multiblock forms sucessfully.
  3. Removing frames from pipes using a crowbar.
  4. The multiblock thinks it's still formed.

Additional Information

image

@MCTian-mi MCTian-mi added the status: unverified Issue is unverified label Aug 11, 2024
@MCTian-mi
Copy link
Contributor Author

The reason why a multiblock isn't invalidiating itself is probably the blockstate isn't changed before and after the removal of frames, which let it pass the cach checking.

M-W-K added a commit to M-W-K/GregTechCEu that referenced this issue Aug 15, 2024
@M-W-K M-W-K linked a pull request Aug 15, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: unverified Issue is unverified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant