Merge pull request #5 from Greenzie/greenzienick/update-max-sentence-…

…length Update max sentence length to 84
Greenzie · Jul 17, 2023 · 45fe868 · 45fe868
2 parents ca3949b + dfd7492
commit 45fe868
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -2,6 +2,10 @@
 Changelog for package greenzie_ntrip_client
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+1.2.3 (2023-06-26)
+------------------
+* Changed the default NMEA Max Message Length to 84
+
 1.2.2 (2023-03-14)
 ------------------
 * Adds ability to publish raw RTCM into uint8 multiarray

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -43,4 +43,4 @@ catkin_install_python(PROGRAMS
 catkin_python_setup()
 
 ## Install the launch files
-install(DIRECTORY launch/ DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}/launch)
+install(DIRECTORY launch/ DESTINATION ${CATKIN_PACKAGE_SHARE_DESTINATION}/launch)
diff --git a/debian/rules b/debian/rules
@@ -35,6 +35,7 @@ override_dh_auto_configure:
 		-DCATKIN_BUILD_BINARY_PACKAGE="1" \
 		-DCMAKE_INSTALL_PREFIX="/opt/ros/noetic" \
 		-DCMAKE_PREFIX_PATH="/opt/ros/noetic" \
+                -DSETUPTOOLS_DEB_LAYOUT=OFF \
 		$(BUILD_TESTING_ARG)
 
 override_dh_auto_build:

diff --git a/launch/ntrip_client.launch b/launch/ntrip_client.launch
@@ -60,7 +60,10 @@
     <param name="rtcm_frame_id" value="odom" />
 
     <!-- Optional parameters that will allow for longer or shorter NMEA messages. Standard max length for NMEA is 82 -->
-    <param name="nmea_max_length" value="83" />
+    <!-- We have increased the max NMEA length due to using a "High Precision" NMEA message which is largeer than the 
+    standard length. Max length of this extended sentence is currently unknown but has been observed at 84 bytes -->
+    <!-- Standard NMEA = 82 Bytes, High Precision = 84 bytes (?) -->
+    <param name="nmea_max_length" value="84" />
     <param name="nmea_min_length" value="3" />
 
     <!-- Use this parameter to change the type of RTCM message published by the node. Defaults to "mavros_msgs", but we also support "rtcm_msgs" -->