Add a configuration for disabling to cache JSON emission data #555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Support dynamic update for emission data JSON file.
It is useful if we can update emission data when we use custom data via JSON datasource.
Currently JSON datasource would cache all of data in JSON on memory, so the update would not propagate even if it is updated. We have to restart WebAPI when we need to update emission data. It is not good for system operation.
I want to introduce
CacheJsonData
into JSON datasource configuration. If the user set it tofalse
, JSON datasource would read emission data JSON file everytime when the request happens. This option is set totrue
by default, so this PR does not break current behavior.Changes
Checklist
Are there API Changes?
No
Is this a breaking change?
No